Commit graph

18 commits

Author SHA1 Message Date
Sacha Greif
8903efc672 fix embody profiling issue and make categories prefillable 2015-10-20 11:56:02 +09:00
Sacha Greif
dafae9b57c working on permissions and router filters 2015-09-19 10:33:37 +09:00
Sacha Greif
25545e60b9 add afterEmbedlyPrefill callback 2015-09-14 17:11:53 +09:00
Sacha Greif
836e95bb49 fix thumbnail dimensions 2015-07-22 15:06:03 +09:00
Sacha Greif
3f6be9e15b various CSS and template tweaks 2015-07-17 16:17:26 +09:00
Maxime Quandalle
94c6121d91 Improve jsHint consistency
This commit touch a lot of lines of code with the goal to be more
rigorous about JavaScript code conventions defined in the `.jshintrc`.

Some modification:

* Add a list of used global symbols in the corresponding section of
  `.jshintrc`
* Use local variables instead of global in a lot of places where the
  keyword `var` was mistakenly forgotten
* Add missing semi-colons after instructions
* Add new lines at the end of files
* Remove trailing whitespaces
* Use newer name of some Meteor APIs, eg `addFiles` instead of
  `add_files`
* Add missing `break` statements in `switch` blocks
* Use `===` instead of `==` and `!==` instead of `!=`
* Remove unused variables

This commit should also fix a few bugs due to this lack of rigor. One
example of that was the test `typeof navElements === "array"` that was
never true because in JavaScript, `typeof [] === "object"`, we
replaced this test by the `_.isArray` method provided by underscore.
It might also fix some potential collision related to global
variables.

There is still plenty of work until Telescope code base passes jsHint
validation, but at least this commit is a step in the right direction.
2015-05-01 18:38:27 +02:00
Sacha Greif
08c6e373fc bringing packages back into core repo after all 2015-04-22 07:50:11 +09:00
Sacha Greif
43b7256680 Packageifying… 2015-04-21 11:02:02 +09:00
Delgermurun
057580b793 Settings package 2015-03-28 18:38:20 +09:00
Delgermurun
5cd7c53ff7 Messages package 2015-03-27 16:38:47 +08:00
Sacha Greif
05cfd0f4a1 add link for regenerating thumbnail 2015-01-19 15:32:08 +09:00
Sacha Greif
78cf9b8439 fix #617 2014-12-12 08:26:10 +09:00
Sacha Greif
baf7aec813 test if Embedly key exists, and if not show message 2014-12-11 15:36:49 +09:00
Sacha Greif
5a868730da Add link for clearing thumbnail (fix #607) 2014-12-10 17:00:22 +09:00
Sacha Greif
97804989a3 use console.log() instead of throwing error to prevent post submit interruption (fix #607) 2014-12-10 10:14:27 +09:00
Sacha Greif
b6c54c106d renaming errors to messages 2014-12-06 17:41:15 +09:00
Sacha Greif
ff8bf40694 Merge branch 'telescope-master-semantic-messages' of https://github.com/AdmitHub/Telescope into AdmitHub-telescope-master-semantic-messages
Conflicts:
	client/helpers/handlebars.js
	client/views/comments/comment_edit.js
	client/views/comments/comment_form.js
	client/views/comments/comment_item.js
	client/views/posts/modules/post_upvote.js
	client/views/posts/post_edit.js
	client/views/posts/post_submit.js
	client/views/users/user_edit.js
	client/views/users/user_email.js
	lib/router.js
	packages/telescope-tags/lib/client/views/category_item.js
2014-12-06 17:34:08 +09:00
Sacha Greif
9bf9ee6f30 renaming embedly package 2014-12-03 08:43:26 +09:00
Renamed from packages/telescope-module-embedly/lib/client/autoform-postthumbnail.js (Browse further)