Commit graph

54 commits

Author SHA1 Message Date
Sacha Greif
0fd0407d4e working on users package and migrating email_hash to emailHash 2015-05-06 12:16:50 +09:00
Maxime Quandalle
94c6121d91 Improve jsHint consistency
This commit touch a lot of lines of code with the goal to be more
rigorous about JavaScript code conventions defined in the `.jshintrc`.

Some modification:

* Add a list of used global symbols in the corresponding section of
  `.jshintrc`
* Use local variables instead of global in a lot of places where the
  keyword `var` was mistakenly forgotten
* Add missing semi-colons after instructions
* Add new lines at the end of files
* Remove trailing whitespaces
* Use newer name of some Meteor APIs, eg `addFiles` instead of
  `add_files`
* Add missing `break` statements in `switch` blocks
* Use `===` instead of `==` and `!==` instead of `!=`
* Remove unused variables

This commit should also fix a few bugs due to this lack of rigor. One
example of that was the test `typeof navElements === "array"` that was
never true because in JavaScript, `typeof [] === "object"`, we
replaced this test by the `_.isArray` method provided by underscore.
It might also fix some potential collision related to global
variables.

There is still plenty of work until Telescope code base passes jsHint
validation, but at least this commit is a step in the right direction.
2015-05-01 18:38:27 +02:00
Sacha Greif
40d38d1364 clean up comment edit form; continue namespacing users.telescope 2015-04-28 15:54:19 +09:00
Sacha Greif
0643437c67 Settings.addToSchema -> Settings.registerField 2015-04-25 13:11:28 +09:00
Sacha Greif
d0c97e7ba9 manually merging in changes from user accounts branch 2015-04-25 12:39:07 +09:00
Sacha Greif
36e2d063ce nicer API namespacing 2015-04-24 09:48:36 +09:00
Sacha Greif
8e5446cc75 refactoring custom fields 2015-04-24 09:28:50 +09:00
Sacha Greif
ab77526a0f namespacing and refactoring template modules 2015-04-23 17:45:37 +09:00
Sacha Greif
478e7ce934 more callback namespacing and refactoring 2015-04-23 16:53:20 +09:00
Sacha Greif
bd290058d7 completely refactoring callback hooks system 2015-04-23 15:42:05 +09:00
Sacha Greif
04061aca9e change callback syntax and add return statement 2015-04-23 11:24:59 +09:00
Sacha Greif
93a3861265 trackEvent > Events.track; add files to telescope:core 2015-04-22 11:49:42 +09:00
Sacha Greif
08c6e373fc bringing packages back into core repo after all 2015-04-22 07:50:11 +09:00
Sacha Greif
3d383e06e1 more packageification; removed meteor hacks:npm; changed telescope-blank to custom 2015-04-21 11:42:47 +09:00
Sacha Greif
50fc3eb11a Merge branch 'namespace' of https://github.com/TelescopeJS/Telescope into namespace
# Conflicts:
#	lib/users.js
#	packages/telescope-base/lib/base.js
#	packages/telescope-base/package.js
#	packages/telescope-lib
2015-04-20 13:57:37 +09:00
Delgermurun
666577f4cb Template[getTemplate('XYZ')] => Template.XYZ 2015-04-13 14:52:03 +09:00
Sacha Greif
cb7b4164ab collapse user menu by default 2015-04-08 11:57:53 +09:00
Delgermurun
057580b793 Settings package 2015-03-28 18:38:20 +09:00
Sacha Greif
35efbeb3ee refactoring menu component 2015-03-28 10:54:41 +09:00
Sacha Greif
3f323cd9cb fix dropdown padding 2015-03-27 14:40:11 +09:00
Sacha Greif
8fc95a316c fix mobile nav 2015-03-24 17:03:37 +09:00
Sacha Greif
f59ad553b6 close dropdown when clicking "mark all as read" 2015-03-23 11:35:49 +09:00
Sacha Greif
9c5d3534cb refactoring dropdown CSS 2015-03-23 11:28:36 +09:00
Sacha Greif
51b52da004 working on admin menu 2015-03-23 10:32:56 +09:00
Sacha Greif
7de8974fc4 fixing top nav & notifications 2015-03-22 12:27:05 +09:00
Sacha Greif
b992538c7e fix #737 2015-02-01 20:44:13 +09:00
Sacha Greif
ea1521d141 do not notify users of their own posts 2015-01-27 12:34:37 +09:00
Sacha Greif
c38c1c6434 fixing email notification templates 2015-01-22 09:19:52 +09:00
Sacha Greif
333b64ae45 adding notifications for approved posts for both admins and end users 2015-01-21 16:47:22 +09:00
Sacha Greif
3b51d0ef1c bunch of small fixes 2015-01-20 16:18:27 +09:00
Sacha Greif
bdf9945440 fixing notifications edge cases 2015-01-20 12:35:25 +09:00
Sacha Greif
bc6987dda7 refactoring notifications and adding notifications for post subscribers 2015-01-20 11:59:40 +09:00
Anthony Mayer
f197b930e6 Cleaning up vote click handling functions and adding tests.
Also combining can.upvote and can.downvote and deleting unused permissions function and random cleanup.
2015-01-19 00:04:41 -08:00
Sacha Greif
6a8a6ee8bb working on getting started package 2014-12-31 17:44:21 +09:00
Sacha Greif
f2760f9168 refactoring comment submit method 2014-12-24 10:13:48 +09:00
Sacha Greif
1eb72079b4 adding userCreatedCallbacks callback hook and refactoring user creation 2014-12-13 14:02:45 +09:00
Anthony Mayer
e71be66c57 Should fix various url problems by taking siteUrl into account when getting route urls.
Trying to make as much use of path as possible on the client side.
2014-12-09 09:29:17 -08:00
Anthony Mayer
23b72b9cb8 Switching from manually generating urls to using IronRouter functions.
Using {{pathFor}}, path(), and url() where possible. Passing in path
to Meteor.absoluteUrl() where the IronRouter functions didn't make sense.
Also deleting some random unused code.
2014-12-03 00:06:00 -08:00
Sacha Greif
8a9af125ca Fix #584 2014-12-03 08:45:43 +09:00
Sacha Greif
82aed922a2 fix mark as read bug 2014-12-01 16:53:41 +09:00
Sacha Greif
d2b24794bc working on form i18n 2014-11-30 12:36:56 +09:00
Sacha Greif
0a696ce1e3 internationalizing packages 2014-11-24 11:27:07 +09:00
Sacha Greif
e572274249 i18ning missing strings 2014-11-20 14:55:34 +09:00
Sacha Greif
8cb60619f8 Merge branch 'integrate-tap-i18n' of github.com:theosp/Telescope into theosp-integrate-tap-i18n 2014-11-20 10:31:20 +09:00
Sacha Greif
eb082473ed refactor server-side email template routes 2014-11-19 15:14:54 +09:00
Daniel Chcouri
2605dcb27c Convert translation keys format to tap:i18n standard
all_lower_cased_underscored_sperated names
2014-11-19 00:00:09 +08:00
Sacha Greif
c3eaf39678 refactoring notifications profileUrl and author 2014-11-18 11:05:15 +09:00
Sacha Greif
c335d654c9 fixing missing username in notifications; cleaning up console.logs 2014-11-18 11:00:38 +09:00
Sacha Greif
7b430bff72 re-enable emailNotifications setting 2014-10-07 13:45:48 +09:00
Sacha Greif
521afdc50d Merge branch 'herald-integration' of github.com:Kestanous/Telescope into Kestanous-herald-integration
Conflicts:
	.meteor/versions
	packages/telescope-kadira/versions.json
	packages/telescope-notifications/lib/notifications.js
2014-10-07 10:34:23 +09:00