Maxime Quandalle
94c6121d91
Improve jsHint consistency
...
This commit touch a lot of lines of code with the goal to be more
rigorous about JavaScript code conventions defined in the `.jshintrc`.
Some modification:
* Add a list of used global symbols in the corresponding section of
`.jshintrc`
* Use local variables instead of global in a lot of places where the
keyword `var` was mistakenly forgotten
* Add missing semi-colons after instructions
* Add new lines at the end of files
* Remove trailing whitespaces
* Use newer name of some Meteor APIs, eg `addFiles` instead of
`add_files`
* Add missing `break` statements in `switch` blocks
* Use `===` instead of `==` and `!==` instead of `!=`
* Remove unused variables
This commit should also fix a few bugs due to this lack of rigor. One
example of that was the test `typeof navElements === "array"` that was
never true because in JavaScript, `typeof [] === "object"`, we
replaced this test by the `_.isArray` method provided by underscore.
It might also fix some potential collision related to global
variables.
There is still plenty of work until Telescope code base passes jsHint
validation, but at least this commit is a step in the right direction.
2015-05-01 18:38:27 +02:00
Sacha Greif
44d3768d62
working on template level controllers
2015-04-29 14:38:14 +09:00
Sacha Greif
6d7451fa87
various fixes; started working on template-level sub controller
2015-04-29 12:16:14 +09:00
Sacha Greif
e0b9bf36b7
namespacing user roles
2015-04-27 17:14:07 +09:00
Sacha Greif
78163f1819
namespacing viewParameters
2015-04-27 10:35:06 +09:00
Sacha Greif
964f91aa88
refactoring menus API
2015-04-24 10:49:24 +09:00
Sacha Greif
08c6e373fc
bringing packages back into core repo after all
2015-04-22 07:50:11 +09:00
Sacha Greif
a44ce82a4c
telescope:daily and telescope:singleday
2015-04-20 16:40:23 +09:00
Sacha Greif
50fc3eb11a
Merge branch 'namespace' of https://github.com/TelescopeJS/Telescope into namespace
...
# Conflicts:
# lib/users.js
# packages/telescope-base/lib/base.js
# packages/telescope-base/package.js
# packages/telescope-lib
2015-04-20 13:57:37 +09:00
Delgermurun
16d9eaf0f9
Delete all getTemplate related codes
2015-04-13 16:29:33 +09:00
Delgermurun
666577f4cb
Template[getTemplate('XYZ')] => Template.XYZ
2015-04-13 14:52:03 +09:00
Sacha Greif
ffdbaed70d
Merge branch 'settings-package' of https://github.com/delgermurun/Telescope into delgermurun-settings-package
...
Conflicts:
.meteor/packages
.meteor/versions
client/components/postList/posts_list.js
client/main.js
lib/router/filters.js
lib/router/posts.js
lib/router/users.js
packages/telescope-base/package.js
packages/telescope-daily/lib/routes.js
packages/telescope-module-share/package.js
packages/telescope-seo/lib/routes.js
packages/telescope-seo/lib/seo.js
packages/telescope-seo/package.js
packages/telescope-singleday/lib/routes.js
2015-04-08 09:20:50 +09:00
Sacha Greif
07125f900d
Bring SEO features back into core and refactor SEO package into sitemap package
2015-04-01 11:00:31 +09:00
Delgermurun
057580b793
Settings package
2015-03-28 18:38:20 +09:00
Sacha Greif
e06e5289f8
adding new postListTop zone
2015-03-22 11:19:27 +09:00
Sacha Greif
4de55e5120
working on posts list views navigation
2015-03-22 09:42:58 +09:00
Sacha Greif
0361451953
Fix singleday view bug
2015-02-04 15:23:22 +09:00
Sacha Greif
c38c1c6434
fixing email notification templates
2015-01-22 09:19:52 +09:00
Anthony Mayer
2bafca52e3
Fixing style issues.
...
Also, switching Router.routes[].path to Router.path
2015-01-19 00:48:17 -08:00
Sacha Greif
ae9c1fa59b
Add load more days link
2015-01-09 16:05:00 +09:00
Sacha Greif
49e92a35b4
test for presence of instance.data
2015-01-08 17:42:56 +09:00
Sacha Greif
1ed868dffe
cleaning up posts daily
2015-01-08 17:37:54 +09:00
Sacha Greif
149ebb1ff7
make daily view work
2015-01-08 17:26:58 +09:00
Sacha Greif
56b53e9026
make load more template work again for regular post list
2015-01-08 17:07:17 +09:00
Sacha Greif
672dc4b965
reset post limit when switching days
2015-01-08 16:39:05 +09:00
Sacha Greif
338e251e97
get rid of unnecessary router subscriptions; make day to day nav work
2015-01-08 16:01:51 +09:00
Sacha Greif
535acb9da8
refactoring singleDay package and postsList module
2015-01-08 15:38:07 +09:00
Sacha Greif
47ace39e26
rename files in singleDay package
2015-01-06 14:46:38 +09:00
Sacha Greif
6139bba6c1
Merge branch 'master' into devel
2015-01-06 11:31:00 +09:00
Sacha Greif
b1f575d745
limit to 200 posts max even for admins; sort single day view by score, not baseScore; fix daily view limited to 10 posts bug
2015-01-06 11:26:44 +09:00
Sacha Greif
0a5f30ce71
use "Telescope" as site title when not defined
2015-01-05 16:32:38 +09:00
Sacha Greif
f5354bf69d
renaming viewNav to viewsMenu and adminNav to adminMenu
2015-01-05 10:06:30 +09:00
Sacha Greif
f8cb992069
Adding descriptions in post list pages and showing them in menus.
2014-12-15 09:46:51 +09:00
Sacha Greif
2d911f2836
renaming digest package to singleday package
2014-12-08 11:41:28 +09:00