Commit graph

12 commits

Author SHA1 Message Date
Sacha Greif
7daabf9e42 renaming 2016-02-17 14:27:27 +09:00
Sacha Greif
1469c3a13d simplifying voting code even more 2016-01-03 18:18:09 +01:00
Sacha Greif
558b284f5a refactor voting code 2016-01-02 18:41:45 +01:00
Sacha Greif
c8754f0dd3 register -> add 2015-05-17 15:38:02 +09:00
Sacha Greif
48c6d49c7c propertyName -> fieldName; propertySchema -> fieldSchema 2015-05-10 14:36:47 +09:00
Sacha Greif
1bd34a2bf1 working on documentation 2015-05-07 18:00:23 +09:00
Sacha Greif
fcc290c55f fixing comment and post edit before hooks 2015-05-04 12:32:00 +09:00
Sacha Greif
be35c98822 Add third "constant" parameter to callbacks; split callbacks.run into run and runAsync; split postEdit and commentEdit in two 2015-05-04 10:19:50 +09:00
Maxime Quandalle
94c6121d91 Improve jsHint consistency
This commit touch a lot of lines of code with the goal to be more
rigorous about JavaScript code conventions defined in the `.jshintrc`.

Some modification:

* Add a list of used global symbols in the corresponding section of
  `.jshintrc`
* Use local variables instead of global in a lot of places where the
  keyword `var` was mistakenly forgotten
* Add missing semi-colons after instructions
* Add new lines at the end of files
* Remove trailing whitespaces
* Use newer name of some Meteor APIs, eg `addFiles` instead of
  `add_files`
* Add missing `break` statements in `switch` blocks
* Use `===` instead of `==` and `!==` instead of `!=`
* Remove unused variables

This commit should also fix a few bugs due to this lack of rigor. One
example of that was the test `typeof navElements === "array"` that was
never true because in JavaScript, `typeof [] === "object"`, we
replaced this test by the `_.isArray` method provided by underscore.
It might also fix some potential collision related to global
variables.

There is still plenty of work until Telescope code base passes jsHint
validation, but at least this commit is a step in the right direction.
2015-05-01 18:38:27 +02:00
Sacha Greif
01ddf50c3e adding APIs for removing callbacks and modules 2015-04-27 10:10:52 +09:00
Sacha Greif
36e2d063ce nicer API namespacing 2015-04-24 09:48:36 +09:00
Sacha Greif
bd290058d7 completely refactoring callback hooks system 2015-04-23 15:42:05 +09:00