Commit graph

22 commits

Author SHA1 Message Date
Sacha Greif
67e7f0e750 fix search 2015-05-07 10:24:41 +09:00
Sacha Greif
0658f172ea Telescope.viewParameters -> Posts.views; add Posts.views.register function; file clean up; give categories and search route controller their own data function 2015-05-06 17:38:19 +09:00
Maxime Quandalle
94c6121d91 Improve jsHint consistency
This commit touch a lot of lines of code with the goal to be more
rigorous about JavaScript code conventions defined in the `.jshintrc`.

Some modification:

* Add a list of used global symbols in the corresponding section of
  `.jshintrc`
* Use local variables instead of global in a lot of places where the
  keyword `var` was mistakenly forgotten
* Add missing semi-colons after instructions
* Add new lines at the end of files
* Remove trailing whitespaces
* Use newer name of some Meteor APIs, eg `addFiles` instead of
  `add_files`
* Add missing `break` statements in `switch` blocks
* Use `===` instead of `==` and `!==` instead of `!=`
* Remove unused variables

This commit should also fix a few bugs due to this lack of rigor. One
example of that was the test `typeof navElements === "array"` that was
never true because in JavaScript, `typeof [] === "object"`, we
replaced this test by the `_.isArray` method provided by underscore.
It might also fix some potential collision related to global
variables.

There is still plenty of work until Telescope code base passes jsHint
validation, but at least this commit is a step in the right direction.
2015-05-01 18:38:27 +02:00
Sacha Greif
99988b6405 add telescope:core 2015-04-22 08:47:23 +09:00
Sacha Greif
a2e9379577 Namespacing router controllers; starting to packageify publications 2015-04-22 08:13:43 +09:00
Sacha Greif
08c6e373fc bringing packages back into core repo after all 2015-04-22 07:50:11 +09:00
Sacha Greif
3d383e06e1 more packageification; removed meteor hacks:npm; changed telescope-blank to custom 2015-04-21 11:42:47 +09:00
Delgermurun
057580b793 Settings package 2015-03-28 18:38:20 +09:00
Sacha Greif
3339af6cc9 Merge branch 'AdmitHub-search-title-description' into devel
Conflicts:
	packages/telescope-search/lib/client/routes.js
2015-03-26 11:18:37 +09:00
Sacha Greif
2c9aac2580 add category titles; do not show posts views nav on category pages 2015-03-25 12:30:55 +09:00
Charlie DeTar
3f0954843f Implement getTitle and getDescription for search 2015-03-24 16:14:36 -06:00
Sacha Greif
51b52da004 working on admin menu 2015-03-23 10:32:56 +09:00
Sacha Greif
0eb3d5d641 Merge branch 'devel' into sidenav 2015-03-21 09:43:59 +09:00
Yalin Wang
02bc33e912 fix bug where last character in search keyword couldn't be cleared
with backspace. issue #825
2015-03-19 20:56:55 -05:00
Sacha Greif
6894de3d2f working on new admin menu 2015-03-18 17:22:43 +09:00
Sacha Greif
f8cb992069 Adding descriptions in post list pages and showing them in menus. 2014-12-15 09:46:51 +09:00
Anthony Mayer
494f27bf9b Fixing duplicate search logs. 2014-11-28 17:46:23 -08:00
Charlie DeTar
981700c5c7 Fix telescope-search route for iron:router 1.0
The ``onBeforeAction`` in ``PostsSearchController`` isn't calling ``this.next()``, and so is never dispatching.
2014-11-24 16:43:41 -07:00
Sacha Greif
4838a04f44 updating packages for IR 1.0 2014-11-17 14:53:42 +09:00
Charlie DeTar
582ee672ab Add querystring updates to search
Update and parse a "?q=" query string for search to improve cross-site
linkability.
2014-10-03 15:48:42 -06:00
Sacha Greif
be82db9072 Disable resetScroll; Simplify adminUsers publication; fix search controller 2014-08-28 11:10:31 +09:00
Sacha Greif
21998aa012 putting search in its own package 2014-06-23 11:05:06 +09:00