Commit graph

10 commits

Author SHA1 Message Date
Sacha Greif
f75300529f update self-upvoting calls 2016-02-06 11:13:02 +09:00
Sacha Greif
974b3c70b5 clean up 2015-06-30 19:12:29 +09:00
Sacha Greif
7e518007f1 Disallow $rename 2015-06-30 19:11:25 +09:00
Sacha Greif
c206230ee5 completely refactor notifications code 2015-06-24 15:38:14 +09:00
Sacha Greif
31f3384e85 Split out own comment and post upvote into separate callbacks to make them easier to remove 2015-06-21 11:58:46 +09:00
Sacha Greif
c8754f0dd3 register -> add 2015-05-17 15:38:02 +09:00
Maxime Quandalle
94c6121d91 Improve jsHint consistency
This commit touch a lot of lines of code with the goal to be more
rigorous about JavaScript code conventions defined in the `.jshintrc`.

Some modification:

* Add a list of used global symbols in the corresponding section of
  `.jshintrc`
* Use local variables instead of global in a lot of places where the
  keyword `var` was mistakenly forgotten
* Add missing semi-colons after instructions
* Add new lines at the end of files
* Remove trailing whitespaces
* Use newer name of some Meteor APIs, eg `addFiles` instead of
  `add_files`
* Add missing `break` statements in `switch` blocks
* Use `===` instead of `==` and `!==` instead of `!=`
* Remove unused variables

This commit should also fix a few bugs due to this lack of rigor. One
example of that was the test `typeof navElements === "array"` that was
never true because in JavaScript, `typeof [] === "object"`, we
replaced this test by the `_.isArray` method provided by underscore.
It might also fix some potential collision related to global
variables.

There is still plenty of work until Telescope code base passes jsHint
validation, but at least this commit is a step in the right direction.
2015-05-01 18:38:27 +02:00
Sacha Greif
3f66f1f10c fix voting code 2015-04-28 10:12:35 +09:00
Sacha Greif
36e2d063ce nicer API namespacing 2015-04-24 09:48:36 +09:00
Sacha Greif
478e7ce934 more callback namespacing and refactoring 2015-04-23 16:53:20 +09:00