Commit graph

16 commits

Author SHA1 Message Date
Maxime Quandalle
94c6121d91 Improve jsHint consistency
This commit touch a lot of lines of code with the goal to be more
rigorous about JavaScript code conventions defined in the `.jshintrc`.

Some modification:

* Add a list of used global symbols in the corresponding section of
  `.jshintrc`
* Use local variables instead of global in a lot of places where the
  keyword `var` was mistakenly forgotten
* Add missing semi-colons after instructions
* Add new lines at the end of files
* Remove trailing whitespaces
* Use newer name of some Meteor APIs, eg `addFiles` instead of
  `add_files`
* Add missing `break` statements in `switch` blocks
* Use `===` instead of `==` and `!==` instead of `!=`
* Remove unused variables

This commit should also fix a few bugs due to this lack of rigor. One
example of that was the test `typeof navElements === "array"` that was
never true because in JavaScript, `typeof [] === "object"`, we
replaced this test by the `_.isArray` method provided by underscore.
It might also fix some potential collision related to global
variables.

There is still plenty of work until Telescope code base passes jsHint
validation, but at least this commit is a step in the right direction.
2015-05-01 18:38:27 +02:00
Sacha Greif
08c6e373fc bringing packages back into core repo after all 2015-04-22 07:50:11 +09:00
Sacha Greif
3d383e06e1 more packageification; removed meteor hacks:npm; changed telescope-blank to custom 2015-04-21 11:42:47 +09:00
Delgermurun
057580b793 Settings package 2015-03-28 18:38:20 +09:00
Anthony Mayer
f771093a06 Adding newsletter time setting 2015-01-20 00:11:30 -08:00
Sacha Greif
a5911bf3f7 remove enableFeeds setting; stop synced-cron message logging 2015-01-06 09:51:35 +09:00
Sacha Greif
37ab8d48b9 feeds require to be enabled 2014-12-31 11:54:38 +09:00
Sacha Greif
778c08d544 clean-up 2014-12-30 18:18:00 +09:00
Sacha Greif
0cc668ce05 add setting for enabling newsletter 2014-12-30 13:46:48 +09:00
Sacha Greif
b7ba4b3bc0 Merge branch 'post-by-rss' of https://github.com/delgermurun/Telescope into delgermurun-post-by-rss
Conflicts:
	.meteor/packages
2014-12-18 10:37:49 +09:00
Sacha Greif
ceeb7bf531 clean up newsletter cron code 2014-12-17 11:00:59 +09:00
Delgermurun
f40be395a3 Fixes scheduling cron jobs twice 2014-12-14 19:46:32 +08:00
Sacha Greif
eb082473ed refactor server-side email template routes 2014-11-19 15:14:54 +09:00
Sacha Greif
c335d654c9 fixing missing username in notifications; cleaning up console.logs 2014-11-18 11:00:38 +09:00
Sacha Greif
02b146df83 reenable facebook avatars 2014-09-10 14:57:01 +09:00
Sacha Greif
733f367f37 add embedly and newsletter packages 2014-08-29 10:37:35 +09:00