Commit graph

12 commits

Author SHA1 Message Date
Sacha Greif
0658f172ea Telescope.viewParameters -> Posts.views; add Posts.views.register function; file clean up; give categories and search route controller their own data function 2015-05-06 17:38:19 +09:00
Maxime Quandalle
94c6121d91 Improve jsHint consistency
This commit touch a lot of lines of code with the goal to be more
rigorous about JavaScript code conventions defined in the `.jshintrc`.

Some modification:

* Add a list of used global symbols in the corresponding section of
  `.jshintrc`
* Use local variables instead of global in a lot of places where the
  keyword `var` was mistakenly forgotten
* Add missing semi-colons after instructions
* Add new lines at the end of files
* Remove trailing whitespaces
* Use newer name of some Meteor APIs, eg `addFiles` instead of
  `add_files`
* Add missing `break` statements in `switch` blocks
* Use `===` instead of `==` and `!==` instead of `!=`
* Remove unused variables

This commit should also fix a few bugs due to this lack of rigor. One
example of that was the test `typeof navElements === "array"` that was
never true because in JavaScript, `typeof [] === "object"`, we
replaced this test by the `_.isArray` method provided by underscore.
It might also fix some potential collision related to global
variables.

There is still plenty of work until Telescope code base passes jsHint
validation, but at least this commit is a step in the right direction.
2015-05-01 18:38:27 +02:00
Sacha Greif
78163f1819 namespacing viewParameters 2015-04-27 10:35:06 +09:00
Sacha Greif
9c5e3a56c6 Make optional packages depend on core only 2015-04-22 16:52:42 +09:00
Sacha Greif
e5f1db1208 remove all packages; temporarily disable sitemap package 2015-04-22 12:46:06 +09:00
Sacha Greif
08c6e373fc bringing packages back into core repo after all 2015-04-22 07:50:11 +09:00
Sacha Greif
3d383e06e1 more packageification; removed meteor hacks:npm; changed telescope-blank to custom 2015-04-21 11:42:47 +09:00
Sacha Greif
7a29c64509 telescope:i18n 2015-04-20 15:20:10 +09:00
Sacha Greif
6d980f9325 change package names; remove submodules 2015-04-20 14:58:48 +09:00
Sacha Greif
50fc3eb11a Merge branch 'namespace' of https://github.com/TelescopeJS/Telescope into namespace
# Conflicts:
#	lib/users.js
#	packages/telescope-base/lib/base.js
#	packages/telescope-base/package.js
#	packages/telescope-lib
2015-04-20 13:57:37 +09:00
Sacha Greif
ffdbaed70d Merge branch 'settings-package' of https://github.com/delgermurun/Telescope into delgermurun-settings-package
Conflicts:
	.meteor/packages
	.meteor/versions
	client/components/postList/posts_list.js
	client/main.js
	lib/router/filters.js
	lib/router/posts.js
	lib/router/users.js
	packages/telescope-base/package.js
	packages/telescope-daily/lib/routes.js
	packages/telescope-module-share/package.js
	packages/telescope-seo/lib/routes.js
	packages/telescope-seo/lib/seo.js
	packages/telescope-seo/package.js
	packages/telescope-singleday/lib/routes.js
2015-04-08 09:20:50 +09:00
Sacha Greif
07125f900d Bring SEO features back into core and refactor SEO package into sitemap package 2015-04-01 11:00:31 +09:00