Commit graph

5 commits

Author SHA1 Message Date
Maxime Quandalle
94c6121d91 Improve jsHint consistency
This commit touch a lot of lines of code with the goal to be more
rigorous about JavaScript code conventions defined in the `.jshintrc`.

Some modification:

* Add a list of used global symbols in the corresponding section of
  `.jshintrc`
* Use local variables instead of global in a lot of places where the
  keyword `var` was mistakenly forgotten
* Add missing semi-colons after instructions
* Add new lines at the end of files
* Remove trailing whitespaces
* Use newer name of some Meteor APIs, eg `addFiles` instead of
  `add_files`
* Add missing `break` statements in `switch` blocks
* Use `===` instead of `==` and `!==` instead of `!=`
* Remove unused variables

This commit should also fix a few bugs due to this lack of rigor. One
example of that was the test `typeof navElements === "array"` that was
never true because in JavaScript, `typeof [] === "object"`, we
replaced this test by the `_.isArray` method provided by underscore.
It might also fix some potential collision related to global
variables.

There is still plenty of work until Telescope code base passes jsHint
validation, but at least this commit is a step in the right direction.
2015-05-01 18:38:27 +02:00
Sacha Greif
f2f8f4b2c3 namespacing voting and scoring 2015-04-23 11:11:07 +09:00
Sacha Greif
9c5e3a56c6 Make optional packages depend on core only 2015-04-22 16:52:42 +09:00
Sacha Greif
c5367adb9e adding events, scoring packages; updating users 2015-04-22 08:31:11 +09:00
Sacha Greif
08c6e373fc bringing packages back into core repo after all 2015-04-22 07:50:11 +09:00