Commit graph

7 commits

Author SHA1 Message Date
Maxime Quandalle
94c6121d91 Improve jsHint consistency
This commit touch a lot of lines of code with the goal to be more
rigorous about JavaScript code conventions defined in the `.jshintrc`.

Some modification:

* Add a list of used global symbols in the corresponding section of
  `.jshintrc`
* Use local variables instead of global in a lot of places where the
  keyword `var` was mistakenly forgotten
* Add missing semi-colons after instructions
* Add new lines at the end of files
* Remove trailing whitespaces
* Use newer name of some Meteor APIs, eg `addFiles` instead of
  `add_files`
* Add missing `break` statements in `switch` blocks
* Use `===` instead of `==` and `!==` instead of `!=`
* Remove unused variables

This commit should also fix a few bugs due to this lack of rigor. One
example of that was the test `typeof navElements === "array"` that was
never true because in JavaScript, `typeof [] === "object"`, we
replaced this test by the `_.isArray` method provided by underscore.
It might also fix some potential collision related to global
variables.

There is still plenty of work until Telescope code base passes jsHint
validation, but at least this commit is a step in the right direction.
2015-05-01 18:38:27 +02:00
Sacha Greif
06106ed124 use schema transforms and editableBy property to control AutoForm omitted fields 2015-04-27 17:15:16 +09:00
Sacha Greif
47b7482420 namespace schemas; migrate user profiles 2015-04-27 09:55:29 +09:00
Sacha Greif
799ea244aa getting core packages to work with api.imply 2015-04-22 16:26:01 +09:00
Sacha Greif
5a9b8dd7d2 getting core packages to work 2015-04-22 15:49:46 +09:00
Sacha Greif
93a3861265 trackEvent > Events.track; add files to telescope:core 2015-04-22 11:49:42 +09:00
Sacha Greif
c5367adb9e adding events, scoring packages; updating users 2015-04-22 08:31:11 +09:00