Commit graph

13 commits

Author SHA1 Message Date
Sacha Greif
99b4791b5a fix get/set user settings 2015-05-11 11:09:26 +09:00
Sacha Greif
3c22937896 userCreated -> onCreateUser; fixing getting started package 2015-05-08 11:45:09 +09:00
Sacha Greif
0fd0407d4e working on users package and migrating email_hash to emailHash 2015-05-06 12:16:50 +09:00
Sacha Greif
be35c98822 Add third "constant" parameter to callbacks; split callbacks.run into run and runAsync; split postEdit and commentEdit in two 2015-05-04 10:19:50 +09:00
Maxime Quandalle
94c6121d91 Improve jsHint consistency
This commit touch a lot of lines of code with the goal to be more
rigorous about JavaScript code conventions defined in the `.jshintrc`.

Some modification:

* Add a list of used global symbols in the corresponding section of
  `.jshintrc`
* Use local variables instead of global in a lot of places where the
  keyword `var` was mistakenly forgotten
* Add missing semi-colons after instructions
* Add new lines at the end of files
* Remove trailing whitespaces
* Use newer name of some Meteor APIs, eg `addFiles` instead of
  `add_files`
* Add missing `break` statements in `switch` blocks
* Use `===` instead of `==` and `!==` instead of `!=`
* Remove unused variables

This commit should also fix a few bugs due to this lack of rigor. One
example of that was the test `typeof navElements === "array"` that was
never true because in JavaScript, `typeof [] === "object"`, we
replaced this test by the `_.isArray` method provided by underscore.
It might also fix some potential collision related to global
variables.

There is still plenty of work until Telescope code base passes jsHint
validation, but at least this commit is a step in the right direction.
2015-05-01 18:38:27 +02:00
Sacha Greif
40d38d1364 clean up comment edit form; continue namespacing users.telescope 2015-04-28 15:54:19 +09:00
Sacha Greif
10166402ef use fields method to restrict fields after all 2015-04-28 11:32:53 +09:00
Sacha Greif
06106ed124 use schema transforms and editableBy property to control AutoForm omitted fields 2015-04-27 17:15:16 +09:00
Sacha Greif
0643437c67 Settings.addToSchema -> Settings.registerField 2015-04-25 13:11:28 +09:00
Sacha Greif
ab77526a0f namespacing and refactoring template modules 2015-04-23 17:45:37 +09:00
Sacha Greif
d675b21e27 more namespacing 2015-04-23 10:39:58 +09:00
Sacha Greif
93a3861265 trackEvent > Events.track; add files to telescope:core 2015-04-22 11:49:42 +09:00
Sacha Greif
08c6e373fc bringing packages back into core repo after all 2015-04-22 07:50:11 +09:00