Commit graph

16 commits

Author SHA1 Message Date
Maxime Quandalle
94c6121d91 Improve jsHint consistency
This commit touch a lot of lines of code with the goal to be more
rigorous about JavaScript code conventions defined in the `.jshintrc`.

Some modification:

* Add a list of used global symbols in the corresponding section of
  `.jshintrc`
* Use local variables instead of global in a lot of places where the
  keyword `var` was mistakenly forgotten
* Add missing semi-colons after instructions
* Add new lines at the end of files
* Remove trailing whitespaces
* Use newer name of some Meteor APIs, eg `addFiles` instead of
  `add_files`
* Add missing `break` statements in `switch` blocks
* Use `===` instead of `==` and `!==` instead of `!=`
* Remove unused variables

This commit should also fix a few bugs due to this lack of rigor. One
example of that was the test `typeof navElements === "array"` that was
never true because in JavaScript, `typeof [] === "object"`, we
replaced this test by the `_.isArray` method provided by underscore.
It might also fix some potential collision related to global
variables.

There is still plenty of work until Telescope code base passes jsHint
validation, but at least this commit is a step in the right direction.
2015-05-01 18:38:27 +02:00
Sacha Greif
e0b9bf36b7 namespacing user roles 2015-04-27 17:14:07 +09:00
Sacha Greif
08c6e373fc bringing packages back into core repo after all 2015-04-22 07:50:11 +09:00
Sacha Greif
3d383e06e1 more packageification; removed meteor hacks:npm; changed telescope-blank to custom 2015-04-21 11:42:47 +09:00
Sacha Greif
50fc3eb11a Merge branch 'namespace' of https://github.com/TelescopeJS/Telescope into namespace
# Conflicts:
#	lib/users.js
#	packages/telescope-base/lib/base.js
#	packages/telescope-base/package.js
#	packages/telescope-lib
2015-04-20 13:57:37 +09:00
Delgermurun
057580b793 Settings package 2015-03-28 18:38:20 +09:00
Sacha Greif
7c14e6b065 fix bug with same posts being sent twice 2015-03-16 14:16:32 +09:00
Sacha Greif
aba323695f do not fetch remote resources with juice; upgrade packages 2015-02-22 08:52:20 +01:00
Sacha Greif
1fd47b23f0 fixing newsletter sync/async issue 2015-01-15 09:41:28 +09:00
Delgermurun
0ff3fc7dba rename getParameters to getPostParameters 2014-09-29 15:42:35 +08:00
Sacha Greif
51de4d79db splitting settings form into field sets 2014-09-28 16:31:12 +09:00
Sacha Greif
64df11d9fe Merge branch 'master' of github.com:TelescopeJS/Telescope 2014-09-19 20:17:02 +09:00
Sacha Greif
d78cb03b89 fix comment publication bug 2014-09-19 20:00:22 +09:00
Jeremy Shimko
02e0c58580 one more subtract() arg swap 2014-09-18 16:46:40 -04:00
Sacha Greif
7e34caf0eb Do not mark posts as sent when invoking testCampaign; limit testCampaign to admins 2014-09-18 13:44:50 +09:00
Sacha Greif
733f367f37 add embedly and newsletter packages 2014-08-29 10:37:35 +09:00