Commit graph

7 commits

Author SHA1 Message Date
Sacha Greif
bb32278b5c working on documentation 2015-05-10 13:37:42 +09:00
Maxime Quandalle
94c6121d91 Improve jsHint consistency
This commit touch a lot of lines of code with the goal to be more
rigorous about JavaScript code conventions defined in the `.jshintrc`.

Some modification:

* Add a list of used global symbols in the corresponding section of
  `.jshintrc`
* Use local variables instead of global in a lot of places where the
  keyword `var` was mistakenly forgotten
* Add missing semi-colons after instructions
* Add new lines at the end of files
* Remove trailing whitespaces
* Use newer name of some Meteor APIs, eg `addFiles` instead of
  `add_files`
* Add missing `break` statements in `switch` blocks
* Use `===` instead of `==` and `!==` instead of `!=`
* Remove unused variables

This commit should also fix a few bugs due to this lack of rigor. One
example of that was the test `typeof navElements === "array"` that was
never true because in JavaScript, `typeof [] === "object"`, we
replaced this test by the `_.isArray` method provided by underscore.
It might also fix some potential collision related to global
variables.

There is still plenty of work until Telescope code base passes jsHint
validation, but at least this commit is a step in the right direction.
2015-05-01 18:38:27 +02:00
Sacha Greif
fc8af1c9da owner -> member; set allow/deny for posts, comments, users 2015-04-28 17:15:53 +09:00
Sacha Greif
10166402ef use fields method to restrict fields after all 2015-04-28 11:32:53 +09:00
Sacha Greif
e26fb593ea Using AutoForm for comment submit form 2015-04-28 09:44:43 +09:00
Sacha Greif
e0b9bf36b7 namespacing user roles 2015-04-27 17:14:07 +09:00
Sacha Greif
08c6e373fc bringing packages back into core repo after all 2015-04-22 07:50:11 +09:00