Commit graph

21 commits

Author SHA1 Message Date
Maxime Quandalle
94c6121d91 Improve jsHint consistency
This commit touch a lot of lines of code with the goal to be more
rigorous about JavaScript code conventions defined in the `.jshintrc`.

Some modification:

* Add a list of used global symbols in the corresponding section of
  `.jshintrc`
* Use local variables instead of global in a lot of places where the
  keyword `var` was mistakenly forgotten
* Add missing semi-colons after instructions
* Add new lines at the end of files
* Remove trailing whitespaces
* Use newer name of some Meteor APIs, eg `addFiles` instead of
  `add_files`
* Add missing `break` statements in `switch` blocks
* Use `===` instead of `==` and `!==` instead of `!=`
* Remove unused variables

This commit should also fix a few bugs due to this lack of rigor. One
example of that was the test `typeof navElements === "array"` that was
never true because in JavaScript, `typeof [] === "object"`, we
replaced this test by the `_.isArray` method provided by underscore.
It might also fix some potential collision related to global
variables.

There is still plenty of work until Telescope code base passes jsHint
validation, but at least this commit is a step in the right direction.
2015-05-01 18:38:27 +02:00
Sacha Greif
d0c97e7ba9 manually merging in changes from user accounts branch 2015-04-25 12:39:07 +09:00
Sacha Greif
964f91aa88 refactoring menus API 2015-04-24 10:49:24 +09:00
Sacha Greif
99988b6405 add telescope:core 2015-04-22 08:47:23 +09:00
Sacha Greif
08c6e373fc bringing packages back into core repo after all 2015-04-22 07:50:11 +09:00
Sacha Greif
3d383e06e1 more packageification; removed meteor hacks:npm; changed telescope-blank to custom 2015-04-21 11:42:47 +09:00
Sacha Greif
50fc3eb11a Merge branch 'namespace' of https://github.com/TelescopeJS/Telescope into namespace
# Conflicts:
#	lib/users.js
#	packages/telescope-base/lib/base.js
#	packages/telescope-base/package.js
#	packages/telescope-lib
2015-04-20 13:57:37 +09:00
Delgermurun
16d9eaf0f9 Delete all getTemplate related codes 2015-04-13 16:29:33 +09:00
Delgermurun
666577f4cb Template[getTemplate('XYZ')] => Template.XYZ 2015-04-13 14:52:03 +09:00
Sacha Greif
2b05abf527 adding pages package 2015-04-08 18:23:29 +09:00
Sacha Greif
861a2cda39 cleaning up admin area 2015-03-31 10:04:55 +09:00
Delgermurun
5cd7c53ff7 Messages package 2015-03-27 16:38:47 +08:00
Sacha Greif
51b52da004 working on admin menu 2015-03-23 10:32:56 +09:00
Accentax
557d4e54fb added category assignment 2015-02-09 18:39:50 +00:00
Sacha Greif
f01f084525 feeds can now be assigned to a user 2015-01-14 12:31:09 +09:00
Sacha Greif
f5354bf69d renaming viewNav to viewsMenu and adminNav to adminMenu 2015-01-05 10:06:30 +09:00
Sacha Greif
b70cee68b8 updated autoform 2014-12-29 18:24:26 +09:00
Sacha Greif
51fd6fe975 temporarily remove feed item quickform 2014-12-27 17:56:10 +09:00
Sacha Greif
d4dcd66a57 using auto form for feeds 2014-12-19 14:32:25 +09:00
Sacha Greif
0b751d086c working on post-by-feed package 2014-12-18 16:01:18 +09:00
Sacha Greif
a379f605cf renaming "rss" to "feed" 2014-12-18 10:47:37 +09:00