Commit graph

15 commits

Author SHA1 Message Date
Sacha Greif
7e48d49366 working on post URL slugs 2015-06-18 13:04:38 +09:00
Sacha Greif
b296d87e44 make profileCompletedAsync callback work; make invites work even with Twitter or Facebook accounts 2015-05-19 12:34:27 +09:00
Sacha Greif
bb32278b5c working on documentation 2015-05-10 13:37:42 +09:00
Sacha Greif
fcc290c55f fixing comment and post edit before hooks 2015-05-04 12:32:00 +09:00
Sacha Greif
be35c98822 Add third "constant" parameter to callbacks; split callbacks.run into run and runAsync; split postEdit and commentEdit in two 2015-05-04 10:19:50 +09:00
Jeremy Shimko
fd204b15e3 fix user methods namespace 2015-05-03 13:09:57 -04:00
Maxime Quandalle
94c6121d91 Improve jsHint consistency
This commit touch a lot of lines of code with the goal to be more
rigorous about JavaScript code conventions defined in the `.jshintrc`.

Some modification:

* Add a list of used global symbols in the corresponding section of
  `.jshintrc`
* Use local variables instead of global in a lot of places where the
  keyword `var` was mistakenly forgotten
* Add missing semi-colons after instructions
* Add new lines at the end of files
* Remove trailing whitespaces
* Use newer name of some Meteor APIs, eg `addFiles` instead of
  `add_files`
* Add missing `break` statements in `switch` blocks
* Use `===` instead of `==` and `!==` instead of `!=`
* Remove unused variables

This commit should also fix a few bugs due to this lack of rigor. One
example of that was the test `typeof navElements === "array"` that was
never true because in JavaScript, `typeof [] === "object"`, we
replaced this test by the `_.isArray` method provided by underscore.
It might also fix some potential collision related to global
variables.

There is still plenty of work until Telescope code base passes jsHint
validation, but at least this commit is a step in the right direction.
2015-05-01 18:38:27 +02:00
Sacha Greif
6d7451fa87 various fixes; started working on template-level sub controller 2015-04-29 12:16:14 +09:00
Sacha Greif
40d38d1364 clean up comment edit form; continue namespacing users.telescope 2015-04-28 15:54:19 +09:00
Sacha Greif
10166402ef use fields method to restrict fields after all 2015-04-28 11:32:53 +09:00
Sacha Greif
4685c32fc1 using Users.can.editField for post and comment submit and edit methods 2015-04-28 10:45:00 +09:00
Sacha Greif
e0b9bf36b7 namespacing user roles 2015-04-27 17:14:07 +09:00
Sacha Greif
36e2d063ce nicer API namespacing 2015-04-24 09:48:36 +09:00
Sacha Greif
bd290058d7 completely refactoring callback hooks system 2015-04-23 15:42:05 +09:00
Sacha Greif
08c6e373fc bringing packages back into core repo after all 2015-04-22 07:50:11 +09:00