hiro/Vulcan
1
0
Fork 0
mirror of https://github.com/vale981/Vulcan synced 2025-03-06 10:01:40 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

Improve onEdit behavior: if any onEdit returns null, unset the field

Browse source
This commit is contained in:
SachaG 2017-05-23 09:48:31 +09:00
parent ea4fb84d06
commit e07a0b1477
1 changed files with 11 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
packages/vulcan-lib/lib/server/mutations.js
View file

@ -65,7 +65,7 @@ export const newMutation = ({ collection, document, currentUser, validate, conte
// run onInsert step // run onInsert step
_.keys(schema).forEach(fieldName => { _.keys(schema).forEach(fieldName => {
if (!newDocument[fieldName] && schema[fieldName].onInsert) { if (schema[fieldName].onInsert) {
const autoValue = schema[fieldName].onInsert(newDocument, currentUser); const autoValue = schema[fieldName].onInsert(newDocument, currentUser);
if (autoValue) { if (autoValue) {
newDocument[fieldName] = autoValue; newDocument[fieldName] = autoValue;
@ -136,12 +136,18 @@ export const editMutation = ({ collection, documentId, set, unset, currentUser,
// run onEdit step // run onEdit step
_.keys(schema).forEach(fieldName => { _.keys(schema).forEach(fieldName => {
if (!document[fieldName] && schema[fieldName].onEdit) {
if (schema[fieldName].onEdit) {
const autoValue = schema[fieldName].onEdit(modifier, document, currentUser); const autoValue = schema[fieldName].onEdit(modifier, document, currentUser);
if (autoValue) { if (typeof autoValue !== 'undefined') {
if (autoValue === null) {
// if any autoValue returns null, then unset the field
modifier.$unset[fieldName] = true;
} else {
modifier.$set[fieldName] = autoValue; modifier.$set[fieldName] = autoValue;
} }
} }
}
}); });
// run sync callbacks (on mongo modifier) // run sync callbacks (on mongo modifier)
@ -194,7 +200,7 @@ export const removeMutation = ({ collection, documentId, currentUser, validate,
// run onRemove step // run onRemove step
_.keys(schema).forEach(fieldName => { _.keys(schema).forEach(fieldName => {
if (!document[fieldName] && schema[fieldName].onRemove) { if (schema[fieldName].onRemove) {
schema[fieldName].onRemove(document, currentUser); schema[fieldName].onRemove(document, currentUser);
} }
}); });