Merge pull request #766 from ndarilek/master

Various accessibility fixes, mainly hiding unnecessary elements from scr...
This commit is contained in:
Sacha Greif 2015-03-10 10:49:20 +09:00
commit bdc3e4eba4
13 changed files with 21 additions and 18 deletions

View file

@ -7,16 +7,16 @@
<div class="comment-content">
<div class="comment-actions {{#if upvoted}}upvoted{{else}}not-upvoted{{/if}} {{#if downvoted}}downvoted{{else}}not-downvoted{{/if}}">
<a class="upvote" href="#">
<i class="icon-up"></i>
<i class="icon-up" aria-hidden="true"></i>
<span>{{_ "upvote"}}</span>
</a>
<a class="downvote" href="#">
<i class="icon-down"></i>
<i class="icon-down" aria-hidden="true"></i>
<span>{{_ "downvote"}}</span>
</a>
</div>
<div class="comment-meta">
<div class="user-avatar avatar-medium">{{> avatar userId=userId shape="circle"}}</div>
<div class="user-avatar avatar-medium" aria-hidden="true">{{> avatar userId=userId shape="circle"}}</div>
<a class="comment-username" href="{{profileUrl}}">{{authorName}}</a>
<span class="comment-time">{{timeAgo ago}},</span>
<span class="points">{{upvotes}}</span> <span class="unit">points </span>

View file

@ -1,5 +1,5 @@
<template name="comment_list">
<ul class="comments comment-list">
<ul class="comments comment-list" aria-live="polite">
{{#each child_comments}}
{{> UI.dynamic template=comment_item}}
{{/each}}

View file

@ -8,7 +8,7 @@
{{/with}}
{{#with comment}}
<ul class="selected-comment">
<ul class="selected-comment" aria-live="polite">
{{> UI.dynamic template=comment_item}}
</ul>
{{/with}}

View file

@ -1,6 +1,6 @@
<template name="postAdmin">
{{#if isAdmin}}
<div class="post-meta-item">
<div class="post-meta-item" aria-live="off">
{{#if showApprove}}
| <a href="#" class="approve-link goto-edit">{{_ "approve"}}</a>
{{/if}}

View file

@ -1,11 +1,11 @@
<template name="postAvatars">
<a href="{{profileUrl userId}}" class="avatar-link avatar-small author-avatar">
<a href="{{profileUrl userId}}" class="avatar-link avatar-small author-avatar" aria-hidden="true">
{{> avatar userId=userId shape="circle"}}
</a>
{{#if commenters}}
<div class="post-commenters">
{{#each commenters}}
<a href="{{profileUrl this}}" class="avatar-link avatar-small commenter-avatar">
<a href="{{profileUrl this}}" class="avatar-link avatar-small commenter-avatar" aria-hidden="true">
{{> avatar userId=this shape="circle"}}
</a>
{{/each}}

View file

@ -1,6 +1,7 @@
<template name="postDiscuss">
<a class="discuss-link go-to-comments action" href="/posts/{{_id}}" title="{{_ 'discuss'}}">
<i class="action-icon icon-comment"></i>
<i class="action-icon icon-comment" aria-hidden="true"></i>
<span class="action-count">{{commentCount}}</span>
<span class="sr-only"> {{_ "comments"}}</span>
</a>
</template>

View file

@ -1,5 +1,5 @@
<template name="postInfo">
<div class="post-meta-item">
<div class="post-meta-item" aria-live="off">
<span class="points">{{baseScore}}</span>
<span class="unit">{{pointsUnitDisplayText}}</span>
{{#if postedAt}}<span class="post-time">{{timeAgo postedAt}}</span>{{/if}}

View file

@ -1,3 +1,3 @@
<template name="postRank">
<div class="post-rank-inner"><span>{{oneBasedRank}}</span></div>
<div class="post-rank-inner" aria-live="off"><span>{{oneBasedRank}}</span></div>
</template>

View file

@ -1,11 +1,13 @@
<template name="postUpvote">
{{#if upvoted}}
<span class="upvote-link voted action" title="{{_ "upvoted"}}">
<i class="icon-check action-icon"></i>
<i class="icon-check action-icon" aria-hidden></i>
<span class="sr-only">{{_ "upvoted"}}</span>
</span>
{{else}}
<a class="upvote-link not-voted action" href="#" title="{{_ "upvote_"}}">
<i class="icon-up action-icon"></i>
<i class="icon-up action-icon" aria-hidden="true"></i>
<span class="sr-only">{{_ "upvote_"}}</span>
</a>
{{/if}}
</template>

View file

@ -1,7 +1,7 @@
<template name="posts_list">
<div class="posts-wrapper grid grid-module">
{{> UI.dynamic template=postsListIncoming data=incoming}}
<div class="posts list {{postsLayout}}">
<div class="posts list {{postsLayout}}" aria-live="polite">
{{#each postsCursor}}
{{> UI.dynamic template=before_post_item}}
{{> UI.dynamic template=post_item}}

View file

@ -2,7 +2,7 @@
<div class="user-profile grid grid-module">
<table>
<tr>
<td colspan="2">{{> avatar user=this size="large" shape="circle"}}</td>
<td colspan="2" aria-hidden="true">{{> avatar user=this size="large" shape="circle"}}</td>
</tr>
{{#if isAdmin}}
<tr>

View file

@ -1,6 +1,6 @@
<template name="user_item">
<tr class="user">
<td>{{> avatar user=this shape="circle"}}</td>
<td aria-hidden="true">{{> avatar user=this shape="circle"}}</td>
<td>
<a href="{{getProfileUrl}}">{{displayName}}</a>
<br/>

View file

@ -1,8 +1,8 @@
<template name="postThumbnail">
{{#if thumbnailUrl}}
<div class="post-thumbnail">
<div class="post-thumbnail" aria-hidden="true">
<a class="post-thumbnail-link {{playVideoClass}}" href="{{postLink}}" target="_blank">
<img class="post-thumbnail-image" src="{{thumbnailUrl}}" onerror="this.style.display='none';"/>
<img class="post-thumbnail-image" src="{{thumbnailUrl}}" onerror="this.style.display='none';" aria-hidden="true"/>
</a>
</div>
{{/if}}