From b1e15e9fb1656a239176a9fffbb6718a697e2192 Mon Sep 17 00:00:00 2001 From: Sacha Greif Date: Tue, 1 Mar 2016 14:10:08 +0900 Subject: [PATCH] adding editorconfig, eslintc, etc. --- .editorconfig | 20 ++++++ .eslintrc | 44 ++++++++++++ .gitignore | 4 -- .jshintrc | 190 ++++++++++++++++++++++++++++++++++++++++++++++++++ 4 files changed, 254 insertions(+), 4 deletions(-) create mode 100644 .editorconfig create mode 100644 .eslintrc create mode 100644 .jshintrc diff --git a/.editorconfig b/.editorconfig new file mode 100644 index 000000000..f7932b46a --- /dev/null +++ b/.editorconfig @@ -0,0 +1,20 @@ +# editorconfig.org + +root = true + +[*.{js,html}] + +charset = utf-8 +end_of_line = lf +indent_brace_style = 1TBS +indent_size = 2 +indent_style = space +insert_final_newline = true +max_line_length = 80 +quote_type = auto +spaces_around_operators = true +trim_trailing_whitespace = true + +[*.md] + +trim_trailing_whitespace = false diff --git a/.eslintrc b/.eslintrc new file mode 100644 index 000000000..ba58e8afb --- /dev/null +++ b/.eslintrc @@ -0,0 +1,44 @@ +/* Galaxy's Javascript linting configuration (Meteor) + * + * Documentation on rules can be found at: + * http://eslint.org/docs/rules/ <- Optionally append the rulename + * + * Ensure changes are kept in sync with the base linting configuration. +*/ + +{ + "extends": ".eslintrc-meteor", + "env": { + /* Allows global vars from the Meteor environment to pass and enables certain rules */ + "meteor": true + }, + "rules": { + + /* ---------------- Rules relaxed for Meteor's sake --------------------- */ + + /* allows use of var (remove when we are ready to switch to ES6) */ + "no-var": 0, + + /* allows anonymous functions */ + "func-names": 0, + + /* allows var = function() delcarations */ + "func-style": 0, + + /* relaxes max-len to 100 chars per line */ + "max-len": [2, 100, 2], + + /* relaxes requirement to put all vars at the top of the scope */ + "vars-on-top": 0, + + /* relaxes dangling commas enforcement */ + "comma-dangle": 0, + + /* allows certain non-constructor functions to start with a capital letter, */ + "new-cap": [2, { "capIsNewExceptions": [ + "Match", "Any", "Object", "ObjectIncluding", "OneOf", "Optional", "Where" + ]}], + + /* ---------------------------------------------------------------------- */ + } +} diff --git a/.gitignore b/.gitignore index 3ab64b26d..e1b6be6ca 100644 --- a/.gitignore +++ b/.gitignore @@ -35,10 +35,6 @@ packages_update.py versions -.editorconfig -.eslintrc -.jshintrc - get_file_list.sh packages_update.py publish_package.sh diff --git a/.jshintrc b/.jshintrc new file mode 100644 index 000000000..42953fcb1 --- /dev/null +++ b/.jshintrc @@ -0,0 +1,190 @@ +//.jshintrc +{ + // JSHint Meteor Configuration File + // Match the Meteor Style Guide + // + // By @raix with contributions from @aldeed and @awatson1978 + // Source https://github.com/raix/Meteor-jshintrc + // + // See http://jshint.com/docs/ for more details + + "maxerr" : 50, // {int} Maximum error before stopping + + // Enforcing + "bitwise" : true, // true: Prohibit bitwise operators (&, |, ^, etc.) + "camelcase" : true, // true: Identifiers must be in camelCase + // "curly" : true, // true: Require {} for every new block or scope + "eqeqeq" : true, // true: Require triple equals (===) for comparison + "forin" : true, // true: Require filtering for..in loops with obj.hasOwnProperty() + "immed" : false, // true: Require immediate invocations to be wrapped in parens e.g. `(function () { } ());` + "indent" : 2, // {int} Number of spaces to use for indentation + "latedef" : false, // true: Require variables/functions to be defined before being used + "newcap" : false, // true: Require capitalization of all constructor functions e.g. `new F()` + "noarg" : true, // true: Prohibit use of `arguments.caller` and `arguments.callee` + "noempty" : true, // true: Prohibit use of empty blocks + "nonew" : false, // true: Prohibit use of constructors for side-effects (without assignment) + "plusplus" : false, // true: Prohibit use of `++` & `--` + "quotmark" : false, // Quotation mark consistency: + // false : do nothing (default) + // true : ensure whatever is used is consistent + // "single" : require single quotes + // "double" : require double quotes + "undef" : true, // true: Require all non-global variables to be declared (prevents global leaks) + "unused" : true, // true: Require all defined variables be used + "strict" : false, // true: Requires all functions run in ES5 Strict Mode + "trailing" : true, // true: Prohibit trailing whitespaces + "maxparams" : false, // {int} Max number of formal params allowed per function + "maxdepth" : false, // {int} Max depth of nested blocks (within functions) + "maxstatements" : false, // {int} Max number statements per function + "maxcomplexity" : false, // {int} Max cyclomatic complexity per function + "maxlen" : false, // {int} Max number of characters per line + + // Relaxing + "asi" : false, // true: Tolerate Automatic Semicolon Insertion (no semicolons) + "boss" : false, // true: Tolerate assignments where comparisons would be expected + "debug" : false, // true: Allow debugger statements e.g. browser breakpoints. + "eqnull" : false, // true: Tolerate use of `== null` + "es5" : false, // true: Allow ES5 syntax (ex: getters and setters) + "esnext" : false, // true: Allow ES.next (ES6) syntax (ex: `const`) + "moz" : false, // true: Allow Mozilla specific syntax (extends and overrides esnext features) + // (ex: `for each`, multiple try/catch, function expression…) + "evil" : false, // true: Tolerate use of `eval` and `new Function()` + "expr" : false, // true: Tolerate `ExpressionStatement` as Programs + "funcscope" : false, // true: Tolerate defining variables inside control statements" + "globalstrict" : true, // true: Allow global "use strict" (also enables 'strict') + "iterator" : false, // true: Tolerate using the `__iterator__` property + "lastsemic" : false, // true: Tolerate omitting a semicolon for the last statement of a 1-line block + "laxbreak" : false, // true: Tolerate possibly unsafe line breakings + "laxcomma" : false, // true: Tolerate comma-first style coding + "loopfunc" : false, // true: Tolerate functions being defined in loops + "multistr" : false, // true: Tolerate multi-line strings + "proto" : false, // true: Tolerate using the `__proto__` property + "scripturl" : false, // true: Tolerate script-targeted URLs + "smarttabs" : false, // true: Tolerate mixed tabs/spaces when used for alignment + "shadow" : false, // true: Allows re-define variables later in code e.g. `var x=1; x=2;` + "sub" : false, // true: Tolerate using `[]` notation when it can still be expressed in dot notation + "supernew" : false, // true: Tolerate `new function () { ... };` and `new Object;` + "validthis" : false, // true: Tolerate using this in a non-constructor function + + // Environments + "browser" : true, // Web Browser (window, document, etc) + "couch" : false, // CouchDB + "devel" : true, // Development/debugging (alert, confirm, etc) + "dojo" : false, // Dojo Toolkit + "jasmine" : true, // Jasmine testing framework + "jquery" : false, // jQuery + "mootools" : false, // MooTools + "node" : false, // Node.js + "nonstandard" : false, // Widely adopted globals (escape, unescape, etc) + "prototypejs" : false, // Prototype and Scriptaculous + "rhino" : false, // Rhino + "worker" : false, // Web Workers + "wsh" : false, // Windows Scripting Host + "yui" : false, // Yahoo User Interface + //"meteor" : false, // Meteor.js + + // Legacy + "nomen" : false, // true: Prohibit dangling `_` in variables + "onevar" : false, // true: Allow only one `var` statement per function + "passfail" : false, // true: Stop on first error + "white" : false, // true: Check against strict whitespace and indentation rules + + // Custom globals, from http://docs.meteor.com, in the order they appear there + "globals" : { + "Meteor": false, + "DDP": false, + "Mongo": false, //Meteor.Collection renamed to Mongo.Collection + "Session": false, + "Accounts": false, + "Template": false, + "Blaze": false, //UI is being renamed Blaze + "UI": false, + "Match": false, + "check": false, + "Tracker": false, //Deps renamed to Tracker + "Deps": false, + "ReactiveVar": false, + "EJSON": false, + "HTTP": false, + "Email": false, + "Assets": false, + "Handlebars": false, // https://github.com/meteor/meteor/wiki/Handlebars + "Package": false, + + // Meteor internals + "DDPServer": false, + "global": false, + "Log": false, + "MongoInternals": false, + "process": false, + "WebApp": false, + "WebAppInternals": false, + + // globals useful when creating Meteor packages + "Npm": false, + "Tinytest": false, + + // Meteor packages + "$": false, + "_": false, + "__": false, + "AccountsTemplates": false, + "AutoForm": false, + "Avatar": false, + "Cookie": false, + "FastRender": false, + "Gravatar": false, + "Herald": false, + "Kadira": false, + "moment": false, + "Random": false, + "RouteController": false, + "Router": false, + "SEO": false, + "SimpleSchema": false, + "SubsManager": false, + "SyncedCron": false, + "TAPi18n": false, + "FlowRouter": false, + + // Telescope collections + "Categories": true, + "Comments": true, + "Feeds": true, + "Invites": true, + "Migrations": true, + "Posts": true, + "Releases": true, + "Searches": true, + "Users": true, + + // Telescope objects + "buildAndSendEmail": true, + "buildEmailNotification": true, + "buildEmailTemplate": true, + "compareVersions": true, + "coreSubscriptions": true, + "daysPerPage": true, + "deleteDummyContent": true, + "Events": true, + "fetchFeeds": true, + "getCategoryUrl": true, + "getEmailTemplate": true, + "getPostCategories": true, + "getTemplate": true, + "getVotePower": true, + "i18n": true, + "InviteSchema": true, + "logEvent": true, + "marked": true, + "Messages": true, + "Pages": true, + "sendEmail": true, + "serveAPI": true, + "Settings": true, + "Telescope": true, + "templates": true, + "themeSettings": true + }, + "esnext": true +}