hiro/Vulcan
1
0
Fork 0
mirror of https://github.com/vale981/Vulcan synced 2025-03-06 18:11:40 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions
Vulcan/packages/telescope-comments/package.js

63 lines
2.1 KiB
JavaScript
Raw Normal View History

creating comments package
2015-04-22 07:50:26 +09:00
Package.describe({
name: "telescope:comments",
summary: "Telescope comments package",
Version bump (0.25.7)
2015-12-30 15:47:46 +09:00
version: "0.25.7",
creating comments package
2015-04-22 07:50:26 +09:00
git: "https://github.com/TelescopeJS/Telescope.git"
});
Package.onUse(function (api) {
api.versionsFrom(['METEOR@1.0']);
api.use([
Version bump (0.25.7)
2015-12-30 15:47:46 +09:00
'telescope:lib@0.25.7',
extract ListContainer and ItemContainer logic
2016-02-16 15:40:37 +09:00
// 'telescope:i18n@0.25.7',
Version bump (0.25.7)
2015-12-30 15:47:46 +09:00
'telescope:settings@0.25.7',
'telescope:users@0.25.7'
creating comments package
2015-04-22 07:50:26 +09:00
]);
Improve jsHint consistency This commit touch a lot of lines of code with the goal to be more rigorous about JavaScript code conventions defined in the `.jshintrc`. Some modification: * Add a list of used global symbols in the corresponding section of `.jshintrc` * Use local variables instead of global in a lot of places where the keyword `var` was mistakenly forgotten * Add missing semi-colons after instructions * Add new lines at the end of files * Remove trailing whitespaces * Use newer name of some Meteor APIs, eg `addFiles` instead of `add_files` * Add missing `break` statements in `switch` blocks * Use `===` instead of `==` and `!==` instead of `!=` * Remove unused variables This commit should also fix a few bugs due to this lack of rigor. One example of that was the test `typeof navElements === "array"` that was never true because in JavaScript, `typeof [] === "object"`, we replaced this test by the `_.isArray` method provided by underscore. It might also fix some potential collision related to global variables. There is still plenty of work until Telescope code base passes jsHint validation, but at least this commit is a step in the right direction.
2015-05-01 18:22:00 +02:00
api.addFiles([
creating comments package
2015-04-22 07:50:26 +09:00
'lib/comments.js',
extract ListContainer and ItemContainer logic
2016-02-16 15:40:37 +09:00
// 'lib/methods.js',
// 'lib/callbacks.js',
// 'lib/views.js',
// 'lib/parameters.js',
// 'lib/helpers.js',
// 'lib/routes.js'
creating comments package
2015-04-22 07:50:26 +09:00
], ['client', 'server']);
Improve jsHint consistency This commit touch a lot of lines of code with the goal to be more rigorous about JavaScript code conventions defined in the `.jshintrc`. Some modification: * Add a list of used global symbols in the corresponding section of `.jshintrc` * Use local variables instead of global in a lot of places where the keyword `var` was mistakenly forgotten * Add missing semi-colons after instructions * Add new lines at the end of files * Remove trailing whitespaces * Use newer name of some Meteor APIs, eg `addFiles` instead of `add_files` * Add missing `break` statements in `switch` blocks * Use `===` instead of `==` and `!==` instead of `!=` * Remove unused variables This commit should also fix a few bugs due to this lack of rigor. One example of that was the test `typeof navElements === "array"` that was never true because in JavaScript, `typeof [] === "object"`, we replaced this test by the `_.isArray` method provided by underscore. It might also fix some potential collision related to global variables. There is still plenty of work until Telescope code base passes jsHint validation, but at least this commit is a step in the right direction.
2015-05-01 18:22:00 +02:00
api.addFiles([
extract ListContainer and ItemContainer logic
2016-02-16 15:40:37 +09:00
// 'lib/client/templates/comment_edit.html',
// 'lib/client/templates/comment_edit.js',
// 'lib/client/templates/comment_submit.html',
// 'lib/client/templates/comment_submit.js',
// 'lib/client/templates/comment_item.html',
// 'lib/client/templates/comment_item.js',
// 'lib/client/templates/comment_list.html',
// 'lib/client/templates/comment_list.js',
// 'lib/client/templates/comment_reply.html',
// 'lib/client/templates/comment_reply.js',
// 'lib/client/templates/comments_list/comments_list.html',
// 'lib/client/templates/comments_list/comments_list.js',
// 'lib/client/templates/comments_list/comments_list_compact.html',
// 'lib/client/templates/comments_list/comments_list_compact.js',
// 'lib/client/templates/comments_list/comments_list_controller.html',
// 'lib/client/templates/comments_list/comments_list_controller.js',
// 'lib/client/templates/comment_controller/comment_controller.html',
// 'lib/client/templates/comment_controller/comment_controller.js'
move posts and comments templates to their respective packages
2015-04-22 12:09:57 +09:00
], ['client']);
Improve jsHint consistency This commit touch a lot of lines of code with the goal to be more rigorous about JavaScript code conventions defined in the `.jshintrc`. Some modification: * Add a list of used global symbols in the corresponding section of `.jshintrc` * Use local variables instead of global in a lot of places where the keyword `var` was mistakenly forgotten * Add missing semi-colons after instructions * Add new lines at the end of files * Remove trailing whitespaces * Use newer name of some Meteor APIs, eg `addFiles` instead of `add_files` * Add missing `break` statements in `switch` blocks * Use `===` instead of `==` and `!==` instead of `!=` * Remove unused variables This commit should also fix a few bugs due to this lack of rigor. One example of that was the test `typeof navElements === "array"` that was never true because in JavaScript, `typeof [] === "object"`, we replaced this test by the `_.isArray` method provided by underscore. It might also fix some potential collision related to global variables. There is still plenty of work until Telescope code base passes jsHint validation, but at least this commit is a step in the right direction.
2015-05-01 18:22:00 +02:00
api.addFiles([
extract ListContainer and ItemContainer logic
2016-02-16 15:40:37 +09:00
// 'lib/server/publications.js',
creating comments package
2015-04-22 07:50:26 +09:00
], ['server']);
extract ListContainer and ItemContainer logic
2016-02-16 15:40:37 +09:00
// var languages = ["ar", "bg", "cs", "da", "de", "el", "en", "es", "et", "fr", "hu", "id", "it", "ja", "kk", "ko", "nl", "pl", "pt-BR", "ro", "ru", "sl", "sv", "th", "tr", "vi", "zh-CN"];
// var languagesPaths = languages.map(function (language) {
// return "i18n/"+language+".i18n.json";
// });
// api.addFiles(languagesPaths, ["client", "server"]);
working on i18n
2015-06-15 19:05:42 +09:00
Namespacing router controllers; starting to packageify publications
2015-04-22 08:13:43 +09:00
api.export('Comments');
creating comments package
2015-04-22 07:50:26 +09:00
});
Reference in a new issue Copy permalink